Skip to content

Conversation

@huntie
Copy link
Member

@huntie huntie commented Oct 24, 2025

Summary:
Similar to performance.measure(), Chrome is adding an optional detail arg to console.timeStamp. Here we implement this for React Native, by direct passing to the "TimeStamp" trace event args.

console.timeStamp() remains an experimental, non-standard API.

Changelog: [Internal]

Differential Revision: D85437162

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 24, 2025

@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85437162.

huntie added a commit to huntie/react-native that referenced this pull request Oct 28, 2025
Summary:

Similar to `performance.measure()`, Chrome is adding an optional `detail` arg to `console.timeStamp`. Here we implement this for React Native, by direct passing to the `"TimeStamp"` trace event args.

[`console.timeStamp()`](https://developer.mozilla.org/en-US/docs/Web/API/console/timeStamp_static) remains an experimental, non-standard API.

Changelog: [Internal]

Differential Revision: D85437162
huntie added a commit to huntie/react-native that referenced this pull request Oct 28, 2025
Summary:

Similar to `performance.measure()`, Chrome is adding an optional `detail` arg to `console.timeStamp`. Here we implement this for React Native, by direct passing to the `"TimeStamp"` trace event args.

[`console.timeStamp()`](https://developer.mozilla.org/en-US/docs/Web/API/console/timeStamp_static) remains an experimental, non-standard API.

Changelog: [Internal]

Differential Revision: D85437162
huntie added a commit to huntie/react-native that referenced this pull request Oct 28, 2025
Summary:

Similar to `performance.measure()`, Chrome is adding an optional `detail` arg to `console.timeStamp`. Here we implement this for React Native, by direct passing to the `"TimeStamp"` trace event args.

[`console.timeStamp()`](https://developer.mozilla.org/en-US/docs/Web/API/console/timeStamp_static) remains an experimental, non-standard API.

Changelog: [Internal]

Differential Revision: D85437162
@huntie huntie force-pushed the export-D85437162 branch 2 times, most recently from 9eac2cc to 4e29ed0 Compare October 30, 2025 12:19
huntie added a commit to huntie/react-native that referenced this pull request Oct 30, 2025
Summary:

Similar to `performance.measure()`, Chrome is adding an optional `detail` arg to `console.timeStamp`. Here we implement this for React Native, by direct passing to the `"TimeStamp"` trace event args.

[`console.timeStamp()`](https://developer.mozilla.org/en-US/docs/Web/API/console/timeStamp_static) remains an experimental, non-standard API.

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D85437162
Summary:

Similar to `performance.measure()`, Chrome is adding an optional `detail` arg to `console.timeStamp`. Here we implement this for React Native, by direct passing to the `"TimeStamp"` trace event args.

[`console.timeStamp()`](https://developer.mozilla.org/en-US/docs/Web/API/console/timeStamp_static) remains an experimental, non-standard API.

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D85437162
@meta-codesync
Copy link

meta-codesync bot commented Oct 30, 2025

This pull request has been merged in 9693a2b.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 30, 2025
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @huntie in 9693a2b

When will my fix make it into a release? | How to file a pick request?

@huntie huntie deleted the export-D85437162 branch October 30, 2025 18:47
huntie added a commit to huntie/react-native that referenced this pull request Oct 30, 2025
Summary:
Changelog: [Internal]

{F1983141005}

Differential Revision: D85888301
huntie added a commit to huntie/react-native that referenced this pull request Oct 31, 2025
Summary:

Changelog: [Internal]

{F1983141005}

Reviewed By: cipolleschi

Differential Revision: D85888301
meta-codesync bot pushed a commit that referenced this pull request Oct 31, 2025
Summary:
Pull Request resolved: #54341

Changelog: [Internal]

{F1983141005}

Reviewed By: cipolleschi

Differential Revision: D85888301

fbshipit-source-id: 54cfaf2995bf0231e661fc11e115266578e1f692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants